Skip to content

BugFix: Enum support in compound keys #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BugFix: Enum support in compound keys #24

wants to merge 3 commits into from

Conversation

abhinand-c
Copy link
Contributor

@abhinand-c abhinand-c commented Jun 12, 2023 •
edited
Loading

Fixes issue #23

When using Enum Field as a key in containing a compound statement, validation fails and doesn't work (raises AssertionError: Invalid compound key definition for type). But the same works if there is no compound key, only enum key.

Changes:

  • fix(Compound Key): Add validation for EnumType, fixes Invalid compound key definition for EnumType
  • feat(Tests): Add test for compound key with Enum types
  • refactor(Compound Key): cleaner logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhinand-c